Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue #9 with tests #15

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fixing issue #9 with tests #15

merged 1 commit into from
Aug 30, 2023

Conversation

ericalli
Copy link
Contributor

I've implemented the proposed solution form issue #9 along with tests.

@ericalli
Copy link
Contributor Author

Any chance this could get merged? Much appreciated!

@ericalli ericalli mentioned this pull request Jun 15, 2023
Open
gastonrobledo
gastonrobledo approved these changes Aug 30, 2023
View reviewed changes
Copy link
Owner

@gastonrobledo gastonrobledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastonrobledo gastonrobledo merged commit b52a267 into gastonrobledo:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonrobledo gastonrobledo gastonrobledo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericalli @gastonrobledo